[incubator-kie-issues#1220] Quarkus example to showcase PIM functionality #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefernan
requested changes
Jul 12, 2024
There was a problem hiding this comment.
@martinweiler great example!
Just requested a few changes related to some missing bits of the compact setup, basically using the data-index addon in the app (and remove it from the docker-compose). A part from that everything works as expected
| This quickstart provides a docker compose template that starts all the required services. This setup ensures that all services are connected with a default configuration. | ||
|
|
||
| - PostgreSQL: 5432 | ||
| - Data Index: 8180 |
There was a problem hiding this comment.
@martinweiler shouldn't we be using the compact setup?
| PGADMIN_CONFIG_MASTER_PASSWORD_REQUIRED: 'False' | ||
| GUNICORN_ACCESS_LOGFILE: '/dev/null' | ||
|
|
||
| data-index: |
There was a problem hiding this comment.
No needed with compact setup
| QUARKUS_DATASOURCE_DB_KIND: postgresql | ||
| KOGITO_JOBS_SERVICE_URL: http://${DOCKER_GATEWAY_HOST}:8080 | ||
| KOGITO_SERVICE_URL: http://${DOCKER_GATEWAY_HOST}:8080 | ||
| KOGITO_DATAINDEX_HTTP_URL: http://${DOCKER_GATEWAY_HOST}:8180 |
There was a problem hiding this comment.
Suggested change
| KOGITO_DATAINDEX_HTTP_URL: http://${DOCKER_GATEWAY_HOST}:8180 | |
| KOGITO_DATAINDEX_HTTP_URL: http://${DOCKER_GATEWAY_HOST}:8080 |
...uarkus-examples/process-instance-migration-quarkus/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
kogito-quarkus-examples/process-instance-migration-quarkus/docker-compose/sql/init.sql
Outdated
Show resolved
Hide resolved
.../process-instance-migration-quarkus/src/main/resources/META-INF/processSVG/addedtask-svg.svg
Outdated
Show resolved
Hide resolved
kogito-quarkus-examples/process-instance-migration-quarkus/docker-compose/README.md
Outdated
Show resolved
Hide resolved
kogito-quarkus-examples/process-instance-migration-quarkus/docker-compose/docker-compose.yml
Outdated
Show resolved
Hide resolved
|
@pefernan thanks for your review. I have updated the example now to be aligned with the compact architecture example. Could you please take another look? Thanks! |
pefernan
approved these changes
Jul 30, 2024
porcelli
approved these changes
Jul 30, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-examples
that referenced
this pull request
Aug 6, 2024
…lity (apache#1979) * [incubator-kie-issues#1220] Quarkus example to showcase PIM functionality * Align example with compact architecture setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#1220